cleanup(libsinsp): make user agent string parametrized

Signed-off-by: lucklypse <[email protected]>
falcosecurity · Sep 22, 2021 · 5727c45 · 5727c45
1 parent 4d9c85e
commit 5727c45
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/cmake/modules/libsinsp.cmake b/cmake/modules/libsinsp.cmake
@@ -9,6 +9,10 @@ option(USE_BUNDLED_DEPS "Enable bundled dependencies instead of using the system
 
 option(WITH_CHISEL "Include chisel implementation" OFF)
 
+if(DEFINED LIBSINSP_USER_AGENT)
+	add_definitions(-DLIBSINSP_USER_AGENT="${LIBSINSP_USER_AGENT}")
+endif()
+
 include(ExternalProject)
 include(libscap)
 if(NOT WIN32)

diff --git a/userspace/libsinsp/mesos_http.cpp b/userspace/libsinsp/mesos_http.cpp
@@ -391,7 +391,7 @@ std::string mesos_http::make_request(uri url, curl_version_info_data* curl_versi
 	{
 		request << '?' << query;
 	}
-	request << " HTTP/1.1\r\nConnection: Keep-Alive\r\nUser-Agent: sysdig";
+	request << " HTTP/1.1\r\nConnection: Keep-Alive\r\nUser-Agent: " LIBSINSP_USER_AGENT;
 	if(curl_version && curl_version->version)
 	{
 		request << " (curl " << curl_version->version << ')';

diff --git a/userspace/libsinsp/sinsp.h b/userspace/libsinsp/sinsp.h
@@ -156,6 +156,14 @@ class metadata_download_params
 	uint32_t m_data_watch_freq_sec = METADATA_DATA_WATCH_FREQ_SEC;
 };
 
+/*!
+  \brief The user agent string to use for any libsinsp connection, can be changed at compile time
+*/
+
+#if !defined(LIBSINSP_USER_AGENT)
+#define LIBSINSP_USER_AGENT "falcosecurity-libs"
+#endif // LIBSINSP_USER_AGENT
+
 /*!
   \brief The default way an event is converted to string by the library
 */

diff --git a/userspace/libsinsp/socket_handler.h b/userspace/libsinsp/socket_handler.h
@@ -181,7 +181,7 @@ class socket_data_handler
 		{
 			request << '?' << query;
 		}
-		request << " HTTP/" << http_version << "\r\n" << m_keep_alive << "User-Agent: sysdig\r\n";
+		request << " HTTP/" << http_version << "\r\n" << m_keep_alive << "User-Agent: " LIBSINSP_USER_AGENT "\r\n";
 		if(!host_and_port.empty())
 		{
 			request << "Host: " << host_and_port << "\r\n";