fix(tests, bpf): correct build and test case failures on s390x #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hendrik Brueckner <[email protected]>
The prctl GET_CHILD_SUBREAPER function stores the PID as `(int *) arg2`. Previously, the arg2 value has been read as `unsigned long` causing endianess issue on s390x resulting in test case failures. Change this to read an integer value similar as in modern BPF. Signed-off-by: Hendrik Brueckner <[email protected]>
poiana
added
release-note-none
dco-signoff: yes
kind/bug
|
Please double check driver/API_VERSION file. See versioning. |
|
Thank you for this PR @hbrueckner ! LGTM! |
|
LGTM label has been added. Git tree hash: a3df6ea4d6b7c4264c52227b2c8bae8949b2acb4
|
Andreagit97
approved these changes
Jun 13, 2023
| @@ -6715,8 +6716,9 @@ FILLER(sys_prctl_x, true) | |||
| /* | |||
| * arg2_int | |||
| */ | |||
| bpf_probe_read_user(&arg2_int,sizeof(arg2_int),(void*)arg2); | |||
| res = bpf_push_s64_to_ring(data, (int)arg2_int); | |||
| reaper_attr = 0; | |||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, hbrueckner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 5.1.0+driver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind failing-test
Any specific area of the project related to this PR?
/area driver-bpf
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Correct a build break on s390x due to a undefined variable. Also correctly read the
prctl GET_CHILD_SUBREAPERvalue to avoid type/endianess issues.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: