Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libscap): fix scap_kmod build with HANDLE() macro #2010

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area libscap

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

Fix build error

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

Please double check driver/API_VERSION file. See versioning.

/hold

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you!

@poiana
Copy link
Contributor

poiana commented Aug 19, 2024

LGTM label has been added.

Git tree hash: 55e076685c9b31d4a67870e3282049cf805d9282

@Andreagit97 Andreagit97 added this to the 0.18.0 milestone Aug 19, 2024
Copy link

Perf diff from master - unit tests

     6.15%     +1.62%  [.] sinsp::next
    11.31%     -1.59%  [.] sinsp_parser::reset
     2.47%     -1.28%  [.] sinsp::fetch_next_event
     3.74%     +1.07%  [.] sinsp_parser::process_event
     3.03%     -0.80%  [.] sinsp_thread_manager::find_thread
     0.80%     +0.70%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     3.24%     -0.69%  [.] sinsp_thread_manager::get_thread_ref
     0.63%     +0.61%  [.] sinsp_parser::parse_context_switch
     1.55%     -0.58%  [.] sinsp_evt::get_ts
     1.00%     +0.45%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>

Perf diff from master - scap file

     8.36%     +4.51%  [.] sinsp_filter_check::tostring
     4.34%     +4.24%  [.] main
    13.14%     -4.08%  [.] libsinsp::runc::match_one_container_id
    17.67%     -3.81%  [.] sinsp_filter_check_thread::extract_single
     8.88%     +2.25%  [.] sinsp_filter_check::rawval_to_string
     8.84%     -1.89%  [.] sinsp_filter_check::apply_transformers
    21.60%     +0.72%  [.] sinsp_filter_check::extract_nocache
     3.95%     +0.32%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     4.45%     -0.19%  [.] sinsp_thread_manager::find_thread
     8.77%     +0.09%  [.] libsinsp::runc::match_container_id

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.12%. Comparing base (f19c71a) to head (4d8f66c).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2010   +/-   ##
=======================================
  Coverage   74.12%   74.12%           
=======================================
  Files         253      253           
  Lines       30805    30805           
  Branches     5404     5396    -8     
=======================================
  Hits        22835    22835           
+ Misses       7951     7942    -9     
- Partials       19       28    +9     
Flag Coverage Δ
libsinsp 74.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucaGuerra
Copy link
Contributor Author

/unhold

Copy link
Contributor

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana
Copy link
Contributor

poiana commented Aug 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, LucaGuerra, Molter73

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,LucaGuerra,Molter73]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit df21b63 into falcosecurity:master Aug 19, 2024
45 of 49 checks passed
@LucaGuerra LucaGuerra deleted the fix/scap-kmod-build branch August 19, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants