Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): flaky thread pool tests #2071

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrgian
Copy link
Contributor

@mrgian mrgian commented Sep 16, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link
Contributor

poiana commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mrgian
Once this PR has been reviewed and has the lgtm label, please assign gnosek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.58%. Comparing base (73bcad2) to head (7d28df8).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2071   +/-   ##
=======================================
  Coverage   73.58%   73.58%           
=======================================
  Files         253      253           
  Lines       31869    31869           
  Branches     5654     5628   -26     
=======================================
+ Hits        23451    23452    +1     
+ Misses       8418     8387   -31     
- Partials        0       30   +30     
Flag Coverage Δ
libsinsp 73.58% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 16, 2024

Perf diff from master - unit tests

     9.08%     +1.62%  [.] sinsp_parser::reset
     8.87%     -1.41%  [.] sinsp::next
     1.18%     +0.94%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     5.35%     +0.79%  [.] next
     4.37%     -0.70%  [.] sinsp_parser::process_event
     1.37%     +0.65%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     0.93%     +0.59%  [.] sinsp_evt::get_ts
     0.60%     +0.48%  [.] sinsp_filter_check::parse_field_name
     1.91%     -0.47%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     0.33%     +0.45%  [.] thread_group_info::get_first_thread

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0132         +0.0132           147           149           147           149
BM_sinsp_split_median                                          +0.0144         +0.0144           147           149           147           149
BM_sinsp_split_stddev                                          -0.2151         -0.2146             0             0             0             0
BM_sinsp_split_cv                                              -0.2253         -0.2249             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0006         -0.0006            57            57            57            57
BM_sinsp_concatenate_paths_relative_path_median                +0.0005         +0.0005            57            57            57            57
BM_sinsp_concatenate_paths_relative_path_stddev                +0.2171         +0.2170             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.2177         +0.2177             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0375         -0.0375            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0307         -0.0307            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.8338         -0.8337             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.8273         -0.8273             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0038         -0.0038            57            56            57            56
BM_sinsp_concatenate_paths_absolute_path_median                -0.0024         -0.0024            56            56            56            56
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.3247         -0.3245             1             0             1             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.3221         -0.3219             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0023         -0.0023           402           401           402           401
BM_sinsp_split_container_image_median                          -0.0035         -0.0035           403           401           403           401
BM_sinsp_split_container_image_stddev                          -0.3724         -0.3727             3             2             3             2
BM_sinsp_split_container_image_cv                              -0.3709         -0.3713             0             0             0             0

@FedeDP
Copy link
Contributor

FedeDP commented Sep 17, 2024

/milestone TBD

@poiana poiana added this to the TBD milestone Sep 17, 2024
Signed-off-by: Gianmatteo Palmieri <[email protected]>
@mrgian mrgian force-pushed the fix-flaky-thread-pool-tests branch from 7d28df8 to 14d0135 Compare October 2, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants