Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to os.tmpdir() if no TMPDIR set #12

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

tony
Copy link
Contributor

@tony tony commented Dec 31, 2023

Fixes #11

Summary

Running coc-biome will create files in each directory a file is opened in:

  • biome-logs/
  • biome-socket-1.4.1

Versions: vim 9.0, as of biome 1.4.1,

Changes

If no TMPDIR set, default to os.tmpdir().

Safe default / fallback, noop for users that already have a TMPDIR in their shell.

On WSL 2 w/ Ubuntu 23.10, this will output to /tmp/biome-logs/ and /tmp/biome-socket-1.4.1, instead of creating a new socket and log directory relatively in each file's directory upon connecting to the language server.

@fannheyward fannheyward merged commit 852d91a into fannheyward:master Jan 2, 2024
1 check passed
@tony tony deleted the tmpdir-fallback branch January 4, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creates biome-logs/ and biome-socket-1.4.1 in each relative directory if no TMPDIR envvar set
2 participants