Skip to content

Commit

Permalink
Return temporaries to being unsigned in secp256k1_fe_sqr_inner
Browse files Browse the repository at this point in the history
These temporaries seem to been inadvertently changed to signed during a refactoring.  Generally, bit shifting is frowned upon for signed values.
  • Loading branch information
roconnor-blockstream authored Nov 14, 2023
1 parent c891c5c commit 1027135
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/field_5x52_int128_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ SECP256K1_INLINE static void secp256k1_fe_mul_inner(uint64_t *r, const uint64_t
SECP256K1_INLINE static void secp256k1_fe_sqr_inner(uint64_t *r, const uint64_t *a) {
secp256k1_uint128 c, d;
uint64_t a0 = a[0], a1 = a[1], a2 = a[2], a3 = a[3], a4 = a[4];
int64_t t3, t4, tx, u0;
uint64_t t3, t4, tx, u0;
const uint64_t M = 0xFFFFFFFFFFFFFULL, R = 0x1000003D10ULL;

VERIFY_BITS(a[0], 56);
Expand Down

0 comments on commit 1027135

Please sign in to comment.