-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New cache sizes for image cache and custom size text improvement #4003
New cache sizes for image cache and custom size text improvement #4003
Conversation
- added options for 8GB and custom size - applied new formatting for custom size (usage)
- applied new formatting for custom size (usage) - removed "exoPlayerCustomCache" in when-case (not used and also can never be reached)
Sometimes I get some internal compile errors saying something like "could not find virtual file Dialog for inline" or similar. But they go away if I clean the project and build again. |
The new variant for custom size usage text maybe is not good for RTL languages or I don't understand how they work. |
Ok, maybe there is a problem with NumberFormatException
|
I also got this error (I did not yet check what exactly happens): ArithmeticException
|
So have two errors or only one? |
The The reason why this I know that it only happens for a size of >4000 TB but still the user can enter such values. |
I forgot that the size also has to be applied. Do I have to change it also somewhere else? |
I have tested with 32 MB and it seems to be getting applied now correctly. |
Changes:
ExoPlayerDiskCacheMaxSize
)Before
After
Also:
valueMax
ofInputNumericDialog
is currently ignored which currently is good