-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Dutch translation for docs/nl/docs/python-types.md
#12158
Conversation
Co-authored-by: Sofie Van Landeghem <[email protected]>
📝 Docs preview for commit f3372fa at: https://73c0fa57.fastapitiangolo.pages.dev Modified Pages |
📝 Docs preview for commit 4d5c6e4 at: https://34e823ce.fastapitiangolo.pages.dev Modified Pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @maxscheijen, thanks for another great translation PR!
I've verified that this translation is in sync with the latest English page on master
and overall it looks really good. I left some small comments, mostly to ensure consistency with the other Dutch translations.
PS: I see that you've been making these edits from your master
branch of your fork. For the next time, the recommended practice is to keep your fork's master
branch synced with the upstream repo, and to create a new branch on your fork whenever you want to open a PR with new edits. This way, the old commits of previous work also won't show up here, and it's easier to track the branches with one branch always corresponding to one PR, etc.
Co-authored-by: Sofie Van Landeghem <[email protected]>
Co-authored-by: Sofie Van Landeghem <[email protected]>
📝 Docs preview for commit 8bb3b4c at: https://fd1e3a5a.fastapitiangolo.pages.dev Modified Pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks again!
PS: I'm keeping track of some of the main decisions in #9200 (first post) to record some of the decisions we're taking and to ensure consistency across pages 😉
That's great! Thanks! |
📝 Docs preview for commit 3aca422 at: https://34e316b6.fastapitiangolo.pages.dev Modified Pages |
Nice, thank you! @maxscheijen @svlandeg 😸 |
No description provided.