workflows: update and pin node versions #717
Conversation
Signed-off-by: Gürgün Dayıoğlu <[email protected]> Co-authored-by: Gürgün Dayıoğlu <[email protected]>
|
windows on node 22 must be skipped for now |
| @@ -17,7 +17,8 @@ on: | |||
|
|
|||
| jobs: | |||
| test: | |||
| uses: fastify/workflows/.github/workflows/plugins-ci.yml@v4.1.0 | |||
| uses: fastify/workflows/.github/workflows/plugins-ci.yml@v4.2.1 | |||
There was a problem hiding this comment.
I believe we can release v4, because the node version is now configurable.
There was a problem hiding this comment.
We’d have to configure every plugin manually, so not sure
I’m pinning libraries right now as they are fastify independent
There was a problem hiding this comment.
No, it has default inside the workflow.
It only need to configure if you do not use the default.
That means we can even use v4 for the current main branch.
It is not limited to the next branch.
There was a problem hiding this comment.
Yes it does, but the default tests for 18, 20, 21
main branches still test for 14, 16, so they would all need manual modification, no?
There was a problem hiding this comment.
But yeah not saying we cannot do it
There was a problem hiding this comment.
Eventually, we need to update all of them back to v4 tag.
We can do this earlier if we release.
There was a problem hiding this comment.
Yeah actually could be good as even next versions currently have hardcoded versions... which in not ideal
No description provided.