feat: add support for tsimp
#410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you rather wait for tsimp to fix their typescript bug before merging or does it not matter to you since it's a dev dependency? |
|
Imho irrelevant for us if the bug is fixed or not. i never heard of tsimp, so i let others decide if it is relevant or not. But codewise i think it is acceptable. |
|
Tests are passing, this can land |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for loading TypeScript plugins via
tsimp.Due to the fact that Node.js versions older than v20 are no longer supported in Fastify v5, I chose not to implement support for the alternate loader script (i.e. --loader=tsimp/loader) that
tsimpprovides.Caution
tsimpcurrently has an open issue and corresponding PR to fix a bug limiting TypeScript support to version 5.5 or earlier (the latest version of TypeScript is v5.6.2). I'm happy to wait on this PR until thetsimpbug is fixed, at which point I will update the TypeScript andtsimpversions.Checklist
npm run testandnpm run benchmarkand the Code of conduct