Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep websocket path on proxy #341

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Keep websocket path on proxy #341

merged 1 commit into from
Mar 19, 2024

Conversation

silnex
Copy link
Contributor

@silnex silnex commented Mar 9, 2024 •
edited
Loading

Checklist

Please understand if there is something I don't understand.

This is a fix for the part where the websocket path cannot be passed as is.
I have added the example and proxying part below.

for example)
wsUpstream: ws://localhost:3030

  1. ws://proxyhost/keep/path > ws://localhost:3030/keep/path
  2. ws://proxyhost/keep2/path > ws://localhost:3030/keep2/path

mcollina
mcollina approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gurgunday
gurgunday approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 37c939e into fastify:master Mar 19, 2024
19 checks passed
thedavidprice referenced this pull request in redwoodjs/redwood Mar 27, 2024
@renovate @thedavidprice
fix(deps): update dependency @fastify/http-proxy to v9.5.0 (#10309)
9bd00e4 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/http-proxy](https://togithub.com/fastify/fastify-http-proxy)
| [`9.4.0` ->
`9.5.0`](https://renovatebot.com/diffs/npm/@fastify%2fhttp-proxy/9.4.0/9.5.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fhttp-proxy/9.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fhttp-proxy/9.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fhttp-proxy/9.4.0/9.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fhttp-proxy/9.4.0/9.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-http-proxy
(@&#8203;fastify/http-proxy)</summary>

###
[`v9.5.0`](https://togithub.com/fastify/fastify-http-proxy/releases/tag/v9.5.0)

[Compare
Source](https://togithub.com/fastify/fastify-http-proxy/compare/v9.4.0...v9.5.0)

#### What's Changed

- chore(.gitignore): add .tap/ dir by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-http-proxy/pull/334](https://togithub.com/fastify/fastify-http-proxy/pull/334)
- chore(types): add internalRewriteLocationHeader in ts types by
[@&#8203;Xa3lis](https://togithub.com/Xa3lis) in
[https://github.com/fastify/fastify-http-proxy/pull/335](https://togithub.com/fastify/fastify-http-proxy/pull/335)
- build(deps-dev): bump
[@&#8203;fastify/websocket](https://togithub.com/fastify/websocket) from
8.3.1 to 9.0.0 by [@&#8203;dependabot](https://togithub.com/dependabot)
in
[https://github.com/fastify/fastify-http-proxy/pull/337](https://togithub.com/fastify/fastify-http-proxy/pull/337)
- build(deps-dev): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 6.21.0 to 7.1.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify-http-proxy/pull/339](https://togithub.com/fastify/fastify-http-proxy/pull/339)
- chore: remove unused make-promises-safe by
[@&#8203;10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in
[https://github.com/fastify/fastify-http-proxy/pull/342](https://togithub.com/fastify/fastify-http-proxy/pull/342)
- Keep websocket path on proxy by
[@&#8203;silnex](https://togithub.com/silnex) in
[https://github.com/fastify/fastify-http-proxy/pull/341](https://togithub.com/fastify/fastify-http-proxy/pull/341)

#### New Contributors

- [@&#8203;Xa3lis](https://togithub.com/Xa3lis) made their first
contribution in
[https://github.com/fastify/fastify-http-proxy/pull/335](https://togithub.com/fastify/fastify-http-proxy/pull/335)
- [@&#8203;10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker)
made their first contribution in
[https://github.com/fastify/fastify-http-proxy/pull/342](https://togithub.com/fastify/fastify-http-proxy/pull/342)
- [@&#8203;silnex](https://togithub.com/silnex) made their first
contribution in
[https://github.com/fastify/fastify-http-proxy/pull/341](https://togithub.com/fastify/fastify-http-proxy/pull/341)

**Full Changelog**:
fastify/fastify-http-proxy@v9.4.0...v9.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: David Price <[email protected]>
thedavidprice referenced this pull request in redwoodjs/redwood Mar 27, 2024
@renovate @thedavidprice
fix(deps): update dependency @fastify/http-proxy to v9.5.0 (#10309)
9f6bf52 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/http-proxy](https://togithub.com/fastify/fastify-http-proxy)
| [`9.4.0` ->
`9.5.0`](https://renovatebot.com/diffs/npm/@fastify%2fhttp-proxy/9.4.0/9.5.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fhttp-proxy/9.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fhttp-proxy/9.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fhttp-proxy/9.4.0/9.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fhttp-proxy/9.4.0/9.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-http-proxy
(@&#8203;fastify/http-proxy)</summary>

###
[`v9.5.0`](https://togithub.com/fastify/fastify-http-proxy/releases/tag/v9.5.0)

[Compare
Source](https://togithub.com/fastify/fastify-http-proxy/compare/v9.4.0...v9.5.0)

#### What's Changed

- chore(.gitignore): add .tap/ dir by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[https://github.com/fastify/fastify-http-proxy/pull/334](https://togithub.com/fastify/fastify-http-proxy/pull/334)
- chore(types): add internalRewriteLocationHeader in ts types by
[@&#8203;Xa3lis](https://togithub.com/Xa3lis) in
[https://github.com/fastify/fastify-http-proxy/pull/335](https://togithub.com/fastify/fastify-http-proxy/pull/335)
- build(deps-dev): bump
[@&#8203;fastify/websocket](https://togithub.com/fastify/websocket) from
8.3.1 to 9.0.0 by [@&#8203;dependabot](https://togithub.com/dependabot)
in
[https://github.com/fastify/fastify-http-proxy/pull/337](https://togithub.com/fastify/fastify-http-proxy/pull/337)
- build(deps-dev): bump
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)
from 6.21.0 to 7.1.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/fastify/fastify-http-proxy/pull/339](https://togithub.com/fastify/fastify-http-proxy/pull/339)
- chore: remove unused make-promises-safe by
[@&#8203;10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in
[https://github.com/fastify/fastify-http-proxy/pull/342](https://togithub.com/fastify/fastify-http-proxy/pull/342)
- Keep websocket path on proxy by
[@&#8203;silnex](https://togithub.com/silnex) in
[https://github.com/fastify/fastify-http-proxy/pull/341](https://togithub.com/fastify/fastify-http-proxy/pull/341)

#### New Contributors

- [@&#8203;Xa3lis](https://togithub.com/Xa3lis) made their first
contribution in
[https://github.com/fastify/fastify-http-proxy/pull/335](https://togithub.com/fastify/fastify-http-proxy/pull/335)
- [@&#8203;10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker)
made their first contribution in
[https://github.com/fastify/fastify-http-proxy/pull/342](https://togithub.com/fastify/fastify-http-proxy/pull/342)
- [@&#8203;silnex](https://togithub.com/silnex) made their first
contribution in
[https://github.com/fastify/fastify-http-proxy/pull/341](https://togithub.com/fastify/fastify-http-proxy/pull/341)

**Full Changelog**:
fastify/fastify-http-proxy@v9.4.0...v9.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: David Price <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silnex @mcollina @gurgunday