Fix uncaught init errors #38
Conversation
|
Note that since the plugin requires leveldown >= 5 and it require node >= 8.6.0 I also patched this plugins' requirement. And since we have node > 8, I'm using |
| next() | ||
| next() | ||
| }) | ||
| .catch(next) |
There was a problem hiding this comment.
Dropping Node 6 is not needed here.
levelMore(opts.name, opts.options, function (err, db) {
if (err) {
next(err)
return
}
fastify.decorate('level', db)
fastify.addHook('onClose', close)
next()
})There was a problem hiding this comment.
But leveldown itself requires >= 8.6.0.
I can revert the change, but I'll also have to remove util.promisify().
There was a problem hiding this comment.
Oh ok. I would prefer to avoid promisify anyway as there is no need to use promises here.
| .register(level, { name: '/test' }) | ||
| .ready(err => { | ||
| t.ok(err) | ||
| t.equal(err.message, 'IO error: /test/LOCK: No such file or directory') |
There was a problem hiding this comment.
I don't think this test would pass on Windows.
It is also trying to write to a file at the root of the file system, which is a bad practice.
I think you can get a similar error if you create a temp file (not directory) and try to open it.
There was a problem hiding this comment.
The idea was to write somewhere impossible (no permission), but I could trigger an error by setting createIfMissing = false in the leveldown options and use "test" like in the other places.
Would that be ok?
|
Closed in #40. |
Without this patch, db initialization errors can go uncaught. I added a test to demonstrate, using "/test" location where it should be impossible to write.
I'm really not used to
tapand I expect there's a much better way to write the test witht.throwsort.rejects. Any help on that end would be appreciated.Checklist
npm run testandnpm run benchmark