Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "chore(package): explicitly declare js module type" #902

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Revert "chore(package): explicitly declare js module type" #902

merged 1 commit into from
Dec 26, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Dec 26, 2023

Reverts #862

If we remove this, then CI will pass and also dependabot PRs should run through.

@Uzlopak Uzlopak requested review from Fdawgs and a team December 26, 2023 02:18
@Uzlopak Uzlopak mentioned this pull request Dec 26, 2023
Merged
4 tasks
Fdawgs
Fdawgs approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@Fdawgs Fdawgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Missed that the js and jsx files in ./pages are ESM when I made that original PR.

@Fdawgs Fdawgs merged commit 7a88685 into master Dec 26, 2023
26 checks passed
@Fdawgs Fdawgs deleted the revert-862-Fdawgs-patch-1 branch December 26, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fdawgs Fdawgs Fdawgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @Fdawgs