Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function overriding chunks onUserInfoResponse #268

Open
2 tasks done
Nerveyyyy opened this issue Jul 30, 2024 · 0 comments · May be fixed by #269
Open
2 tasks done

Function overriding chunks onUserInfoResponse #268

Nerveyyyy opened this issue Jul 30, 2024 · 0 comments · May be fixed by #269
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Nerveyyyy
Copy link

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the bug has not already been reported

Fastify version

4.28.0

Plugin version

7.8.1

Node.js version

20.12.2

Operating system

macOS

Operating system version (i.e. 20.04, 11.3, 10)

Sonoma 14.5

Description

There is a current bug where if the response of User Info is large enough, when the onUserInfoResponse function is called to grab the data via chunks, it is currently overriding the previous chunk that is set. Therefore causing an issue where I get an invalid JSON response since the response is half of the JSON response. This issue has been fixed in the function onDiscoveryResponse. With += chunks instead of = chunks in user info.

Link to code that reproduces the bug

No response

Expected Behavior

Respond with a full JSON without being cut off half way.

@climba03003 climba03003 added bug Something isn't working good first issue Good for newcomers labels Jul 30, 2024
@Eomm Eomm linked a pull request Sep 22, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants