Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed onUserInfoResponse chunks being overridden #269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed onUserInfoResponse chunks being overridden #269

wants to merge 1 commit into from

Conversation

Nerveyyyy
Copy link

@Nerveyyyy Nerveyyyy commented Jul 30, 2024 •
edited
Loading

This PR fixes the issue - 268. Where receiving a large UserInfo response it will chunk the data but override previous chunks instead of adding to it. This therefore causes issues with a partial JSON response which errors the code.

Checklist

climba03003
climba03003 requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide an unit test to ensure the user info is always accumulating instead of replacing on each chunk?

@Eomm Eomm linked an issue Sep 22, 2024 that may be closed by this pull request
Function overriding chunks onUserInfoResponse #268
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@climba03003 climba03003 climba03003 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function overriding chunks onUserInfoResponse
2 participants
@Nerveyyyy @climba03003