-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update README.md with revised information #207
Conversation
The documentation (https://github.com/fastify/fastify-oauth2/blob/master/README.md?plain=1#L230) explained that the refresh token required is actual refresh token. But the refresh token passed to simple-oauth2 's .createToken() method expects the Access Token object with refresh token itself.
Co-authored-by: Manuel Spigolon <[email protected]>
Co-authored-by: Manuel Spigolon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not seem right
Co-authored-by: Rojan Dahal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thanks! |
The documentation (https://github.com/fastify/fastify-oauth2/blob/master/README.md?plain=1#L230) explained that the refresh token required is actual refresh token.
But the refresh token passed to
simple-oauth2
's.createToken()
method expects the Access Token object with refresh token itself.So the documentation is edited to explain that the
.getNewAccessTokenUsingRefreshToken()
method required AccessToken object which is of format{refresh_token: 'eyJhbGciOiJSUzI1NiI...'})
Checklist
npm run test
andnpm run benchmark
and the Code of conduct