feat(chore): implement yandex configuration in preset #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(chore): implement revoke token and revoke all token (fastify#222) * feat(chore): update deps and implement gitlab provider * feat(docs): implement gitlab configuration in preset * feat(chore): implement revokeToken * feat(tests): implement missing test in interface * feat(chore,tests): implement revokeAllToken * feat(chore): implement revokeAllToken --------- Co-authored-by: joris <[email protected]>
Eomm
reviewed
Aug 26, 2023
| @@ -0,0 +1,33 @@ | |||
| const fastify = require('fastify')({ logger: { level: 'trace' } }) | |||
There was a problem hiding this comment.
@fastify/plugins I think the examples/ folder is becoming too big to ship
I would switch to a single generic example and add a custom one only if necessary
Not necessary to do it in this PR tho 👍🏼
Eomm
reviewed
Aug 26, 2023
index.js
Outdated
| authorizeHost: 'https://oauth.yandex.com', | ||
| authorizePath: '/authorize', | ||
| tokenHost: 'https://oauth.yandex.com', | ||
| tokenPath: '/token' |
There was a problem hiding this comment.
Yeap, it has.
POST request to /revoke_token https://yandex.ru/dev/id/doc/en/tokens/token-invalidate#cleartext
So I can add it right now.
There was a problem hiding this comment.
And it is done)
Uzlopak
reviewed
Aug 26, 2023
Uzlopak
reviewed
Aug 26, 2023
| @@ -322,6 +322,17 @@ fastifyOauth2.EPIC_GAMES_CONFIGURATION = { | |||
| tokenPath: '/epic/oauth/v1/token' | |||
| } | |||
|
|
|||
| /** | |||
| * Yandex ID docs https://yandex.ru/dev/id/doc/en/ | |||
There was a problem hiding this comment.
Very good. I also thought that the lack of references is bad. Thank you for adding the reference.
Co-authored-by: Uzlopak <[email protected]>
Uzlopak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct