Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge next into master #241

Merged
merged 6 commits into from
Jun 23, 2024
Merged

Merge next into master #241

merged 6 commits into from
Jun 23, 2024

Conversation

jsumners
Copy link
Member

As titled.

gurgunday and others added 2 commits February 23, 2024 12:22
@gurgunday
update for Fastify v5 (#236)
87f20ab 
* update for v5

* add pre commit
@synapse
upgrade for fastify 5 (#238)
e15b667 
Signed-off-by: Cristian Barlutiu <[email protected]>
gurgunday
gurgunday approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcollina
mcollina approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

CI is failing

@jsumners jsumners requested a review from mcollina June 21, 2024 19:33
@jsumners
Copy link
Member Author

For some reason npm keeps installing the alpha.1 release of Fastify and I just don't have the patience to figure it out today. I'll come back later.

@jsumners jsumners marked this pull request as draft June 21, 2024 19:34
@jsumners
Copy link
Member Author

The only way I could figure out to fix the problem was to mark the mislabeled [email protected] version as deprecated.

@jsumners jsumners marked this pull request as ready for review June 23, 2024 15:41
@jsumners jsumners merged commit 1a5a200 into master Jun 23, 2024
30 checks passed
@jsumners jsumners deleted the next branch June 23, 2024 15:42
@dnlup dnlup mentioned this pull request Oct 14, 2024
Open
@KlemenKozelj KlemenKozelj mentioned this pull request Oct 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

@lilpoozie2005 lilpoozie2005 lilpoozie2005 approved these changes

@mcollina mcollina Awaiting requested review from mcollina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsumners @mcollina @gurgunday @lilpoozie2005 @synapse