-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: spelling corrections #5349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will review properly next week.
FYI, Fastify uses American/Simple English over British/Traditional English, so "Behavior" is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my comments (and subsequent lines that are the same but I left uncommented), this looks good. Please resolve the issues highlighted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Should https://fastify.dev/organisations/ be https://fastify.dev/organizations/ then? Is that a PR you'd be open to (with a redirect of course)? |
I'll leave that up to the @fastify/website team. But I don't think we need to be so pedantic as to break the website. (FYI: I'm American, having never left the country in my 4+ decades [record to be broke in April 🎉], and I routinely write British variants of words before spellcheck kicks in. I'm not a stickler for the variants. We just have a style guide and should adhere to it as much as makes sense for consistency.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I think for consistency sake it should be "organizations", is it hard to add a redirect to "organisations"? Not familiar with what framework the website uses |
@gurgunday the site is built with docusaurus and already uses a plugin for a few other redirects, so it would just take a couple additional lines to that plugin config |
let's do it |
Co-authored-by: Frazer Smith <[email protected]> Signed-off-by: Jamie King <[email protected]>
Just fixing some spelling errors through docs, comments & tests
Checklist
npm run test
andnpm run benchmark
and the Code of conduct