fix: remove-label job uses the wrong repo
#5415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurgunday
changed the title
remove-label job uses the wrong repo
Eomm
approved these changes
Apr 21, 2024
|
@Eomm ok, from |
|
Why is citgm remove-label still running 🤦 |
Open
1 task
This was referenced May 30, 2024
This was referenced Jun 1, 2024
This was referenced Aug 21, 2024
This was referenced Aug 28, 2024
This was referenced Sep 3, 2024
This was referenced Sep 8, 2024
This was referenced Sep 12, 2024
[Snyk] Upgrade: , fastify, graphql, mercurius
WontonSam/apollo-federation-subgraph-compatibility#505
Open
[Snyk] Upgrade: , fastify, graphql, mercurius
WontonSam/apollo-federation-subgraph-compatibility#518
Open
[Snyk] Upgrade: , fastify, graphql, mercurius
WontonSam/apollo-federation-subgraph-compatibility#522
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another issue discovered in the CI,
remove-labeljobs are failing due wrong information being sent to the REST API:https://github.com/fastify/fastify/actions/runs/8772362238/job/24071203586?pr=5413#step:2:13
https://github.com/fastify/fastify/actions/runs/8772362236/job/24071226346?pr=5413#step:2:13
I believe it's choosing the wrong repo, it should be the base repo instead of the owner of the PR's repo
Reference: https://docs.github.com/en/actions/learn-github-actions/contexts#github-context