Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workflow for Fastify Integration testing #269

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Oct 24, 2023

This PR introduces a workflow, which should help us to detect regressions and incompatibilities in fastify. This is relevant especially for the PR #252, where tests of light-my-requests pass, but testing in fastify breaks.

Checklist

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 24, 2023

@Fdawgs

Maybe a workflow which should be generalized in the plugins-ci.yml for dependencies which are integral part of china fastify?

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this triggered from fastify/fastify changes?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 24, 2023

@jsumners

It is not about being triggered when fastify core gets changes. Every change on fastify core results in loading latest version of light-my-request.
It is about ensuring that changes in light-my-request are not breaking fastify. E.g. the changes in #252 by @sirenkovladd are passing the unit tests but are breaking fastify. If I didnt test it like I did in the workflow, I would not know that it broke fastify. Maybe approved the PR and then after release, realize that there is an issue.
This workflow ensures, that we see before merging, that there is something wrong.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 24, 2023

moved the workflow to fastify/workflows.

Dont merge this PR

@Uzlopak Uzlopak changed the title add workflow for Fastify Integration testing DONT MERGE add workflow for Fastify Integration testing Oct 24, 2023
@Uzlopak Uzlopak changed the title DONT MERGE add workflow for Fastify Integration testing add workflow for Fastify Integration testing Oct 27, 2023
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Oct 27, 2023

@Fdawgs
@jsumners
PTAL

@Uzlopak Uzlopak closed this Oct 27, 2023
@Uzlopak Uzlopak merged commit 1e4530d into master Oct 27, 2023
21 checks passed
@Uzlopak Uzlopak deleted the fastify-integration-test branch October 27, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants