Update doc and typings for res.json()

[fralonra]

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows Code of conduct

[RafaelGSS]

LGTM

[mcollina]

Would you mind to add a test for the new type? Il giorno mar 15 ott 2019 alle 07:30 Manuel Spigolon < [email protected]> ha scritto:

…

***@***.**** commented on this pull request. ------------------------------ In README.md <#56 (comment)> : > @@ -140,6 +140,7 @@ Injects a fake request into an HTTP server. - `body` - alias for payload. - `rawPayload` - the raw payload as a Buffer. - `trailers` - an object containing the response trailers. + - `json` - a function that parses string to json. I would improve the description: json() - parse the application/json response payload and returns an object. Throws if the content type is different — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#56?email_source=notifications&email_token=AAAMXY3EFRZXHNT3ZKMACN3QOVIRBA5CNFSM4JAWBWTKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCH5PNFY#pullrequestreview-301659799>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAMXY3GCSZPE7SRV3BKJDDQOVIRBANCNFSM4JAWBWTA> .

[fralonra]

@mcollina
I'm sorry, but I don't understand how to add a test for the new type.

[mcollina]

Just add a call to json() in

light-my-request/test/index.test-d.ts

Line 17 in e9df4c4

inject(dispatch, { method: 'get', url: '/' }, (err, res) => {

.

[fralonra]

@mcollina should I use expectType to test if the type of res.json is Function?

[mcollina]

That'd be nice.

This needs a rebase.

[fralonra]

@mcollina Rebase and then force push? By me?

[mcollina]

I cannot push to your branch. You can also merge master.

[fralonra]

Done. BTW, can you rebase and merge when merging to master? @mcollina

[mcollina]

LGTM