Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore autostart when using fire-and-forget promises. #63

Merged
merged 1 commit into from
Oct 29, 2019
Merged

restore autostart when using fire-and-forget promises. #63

merged 1 commit into from
Oct 29, 2019

Conversation

mcollina
Copy link
Member

This restores a behavior that was lost when adding the Chain capability.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

delvedor
delvedor approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fralonra
fralonra approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@fralonra fralonra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit b59fa39 into master Oct 29, 2019
@climba03003 climba03003 deleted the restore-autostart branch May 23, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor approved these changes

@fralonra fralonra fralonra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcollina @delvedor @fralonra