Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(8.x): use [email protected] #215

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix(8.x): use [email protected] #215

merged 1 commit into from
Sep 13, 2024

Conversation

climba03003
Copy link
Member

@climba03003 climba03003 commented Sep 12, 2024

Since path-to-regexp published new version for it's 6.x release line.
To reduce the breaking change for most users, I consider use 6.3.0 in the 8.x release line for @fastify/middie.
I will deprecated the 8.3.2 version once this is accepted.

Resolves #214

cc @fastify/core

Checklist

@climba03003
Copy link
Member Author

climba03003 commented Sep 12, 2024

Note that the CVE is not updated yet, so it is failing in the Dependency Review.

Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@climba03003 climba03003 changed the title fix: use [email protected] fix(8.x): use [email protected] Sep 12, 2024
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@climba03003
Copy link
Member Author

Tracking on CVE before merging github/advisory-database#4791
It reduces some spam of issues about the alert.

@GitVitor
Copy link

It seems that the merge on advisory-database was merged.

@climba03003 do you think it's ready to be merged?

@climba03003 climba03003 merged commit 0572d55 into v8.x Sep 13, 2024
17 checks passed
@climba03003 climba03003 deleted the use-path-to-regexp-6 branch September 13, 2024 03:58
micalevisk added a commit to micalevisk/nest that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants