Skip to content
This repository has been archived by the owner on Jul 8, 2023. It is now read-only.

add microsoft logo #193

Merged
merged 2 commits into from
Aug 28, 2020
Merged

add microsoft logo #193

merged 2 commits into from
Aug 28, 2020

Conversation

Ethan-Arrowood
Copy link
Member

@Ethan-Arrowood Ethan-Arrowood commented Aug 28, 2020

Checklist

(it took longer to find the svg logo than it did to open this pr 😂)

Copy link
Member

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 8a7fc5d into fastify:master Aug 28, 2020
@Eomm
Copy link
Member

Eomm commented Aug 30, 2020

Does not worth add it in the home page too?

(from mobile I see it only in the org page https://www.fastify.io/organisations/)

@delvedor
Copy link
Member

delvedor commented Aug 30, 2020

@Eomm the home page contains a randomized subset of the orgs, it should change automatically every now and then :)
Am I right @lmammino?

@Eomm
Copy link
Member

Eomm commented Aug 30, 2020

Mmmm looking the code you are right
https://www.github.com/fastify/website/tree/master/src%2Fwebsite%2Flayouts%2Fhome.html

My incognito returns always the same list.
Does it change for you?

@lmammino
Copy link
Member

lmammino commented Aug 30, 2020

Hello guys, I can confirm the home page will randomize the logos and select a subset of them at every build. We can definitely change the logic if we want. It shouldn't be a big deal.

A simple idea might be to add an attribute like pinned: true in the list of logos and then make sure the pinned ones are always selected in the random subset. What do you think?

Anyway, I am thrilled to see the Microsoft logo here ❤️

@mcollina
Copy link
Member

Let's go for pinned.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants