Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backport): exclude Node 14 and 16 on macos (#127) #128

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

gurgunday
Copy link
Member

  • chore: exclude Node 14 and 16 on macos

Related to fastify/.github#37.

This is just a proposal, probably not comprehensive of all the places where a similar change may have to occur, simply to capture that this is possible (and I didn't know until now) to exclude combinations, as documented in https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations

  • remove os matrix from package

Checklist

* chore: exclude Node 14 and 16 on macos

Related to fastify/.github#37.

This is just a proposal, probably not comprehensive of all the places where a similar change may have to occur, simply to capture that this is possible (and I didn't know until now) to exclude combinations, as documented in https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations

Signed-off-by: Simone Busoli <[email protected]>

* remove os matrix from package

---------

Signed-off-by: Simone Busoli <[email protected]>
Co-authored-by: Gürgün Dayıoğlu <[email protected]>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday gurgunday merged commit 0540c8a into v3.y.z Apr 29, 2024
1 check passed
@gurgunday gurgunday deleted the backport branch April 29, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants