chore: extract elasticsearch image version #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpreviero
force-pushed
the
extract-elasticsearch-image-version
branch
from
e7e5d81
to
92b8e4f
Compare
Fdawgs
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid tagging new versions of this repository whenever a new version of elasticsearch image is released or doesn't exist anymore on Docker Hub, extracts the image version as a workflow input.
This will allow driving the version being used from https://github.com/fastify/fastify-elasticsearch/blob/master/.github/workflows/ci.yml directly.
Checklist
runno test and benchmarksnpm run testandnpm run benchmarktests and/or benchmarks are includedno testsdocumentation is changed or addedno documentationand the Code of conduct