[snapshot] Replace Objective-C-style NSMakeRange with Swift-style NSRange.init

[RomanPodymov]

🔑 Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

Get the following message in SnapshotHelper.swift line 182 when running swiftlint: Swift constructors are preferred over legacy convenience functions. I think it would be great to use modern Swift API in fastlane.
This is a very small improvement, but I think all users will enjoy it.

Description

Replace Objective-C-style NSMakeRange(0, simulator.count) with Swift-style NSRange(location: 0, length: simulator.count) (suggested by swiftlint https://github.com/realm/SwiftLint). Delete empty line.
To test my changes I replaced SnapshotHelper.swift from the tag fastlane/2.128.1 with my version of SnapshotHelper.swift and run capture_screenshots. Fastlane generated the same screenshots successfully.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[RomanPodymov]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[janpio]

Looks good. Could you please also increment the version in the last line of the file so this can be merged for release? Thanks.

[mollyIV]

Hey @RomanPodymov ,

Thanks for making this change 🙌

This is a very small improvement, but I think all users will enjoy it.

Absolutely 👍 Slowly, but surely we are making fastlane swift better and better 😉

[janpio]

Thanks for the review @mollyIV (but this is actually not part of fastlane swift, but of the code that the apps run to be able to do snapshot)

[mollyIV]

but this is actually not part of fastlane swift, but of the code that the apps run to be able to do snapshot

Oh, you're right, .swift file extension tricked me up 😅 🙌

[fastlane-bot]

Hey @RomanPodymov 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.129.0 🚀