-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12.9-inch iPad Pro (3rd Gen) is missing #7
Comments
Yes, that device is unfortunately not present with the device frames this is using: https://facebook.design/devices For your other question(s), you should open an issue at https://github.com/fastlane/fastlane/issues |
Same issue. Hope for alternative solution soon. |
Automate curl https://user-images.githubusercontent.com/586910/59685084-413aa480-91d3-11e9-9d1f-2c943317f650.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Space\ Gray.png
# I use WHITE, so I had to add Silver as well while it is the same
# let me know if you have a white frame
curl https://user-images.githubusercontent.com/586910/59685084-413aa480-91d3-11e9-9d1f-2c943317f650.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Silver.png
# Remove last two lines
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
cat >> ~/.fastlane/frameit/latest/offsets.json <<EOL
,
"iPad Pro (12.9-inch) (3rd generation)": {
"offset": "+119+216",
"width": 2048
}
}
}
EOL |
If you don't need this black line (home slider) or has screenshots in landscape mode, you can use latest (29 sept 2019) device mockups from Facebook. curl https://user-images.githubusercontent.com/24507532/66273840-689ba700-e880-11e9-95e6-7ecb63728b2c.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Space\ Gray.png
curl https://user-images.githubusercontent.com/24507532/66273839-66394d00-e880-11e9-85cf-50f4dc0210c5.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Silver.png
# Remove last two lines
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
cat >> ~/.fastlane/frameit/latest/offsets.json <<EOL
,
"iPad Pro (12.9-inch) (3rd generation)": {
"offset": "+200+200",
"width": 2048
}
}
}
EOL |
When the 3rd Gen iPad Pro is added to facebook device library , it could be also properly integrated into fastlane frameit, because fastlane is using this device library. The new iPhones could be added as well! |
@ConfusedVorlon where did the image you posted above come from? |
You can find mockups there - https://facebook.design/devices |
I suspect I manually adjusted one of those images, but I can't remember.
At the time, the facebook devices didn't have a suitably sized frame. Has
that changed?
…On Thu, 21 Nov 2019 at 19:45, JulesMoorhouse ***@***.***> wrote:
@ConfusedVorlon <https://github.com/ConfusedVorlon> where did the image
you posted above come from?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#7?email_source=notifications&email_token=AAEPJHVL5ILKMB7GYHGHDDLQU3QL5A5CNFSM4HFDWJW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE3NS3I#issuecomment-557242733>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEPJHQFWTLBYJP476UBL63QU3QL5ANCNFSM4HFDWJWQ>
.
--
Hobbyist Software is a trading name of Hobbyist Software Limited.
Registered office 12 Fraley Rd, Bristol, BS93BS. Registered in England.
Company no:7876492
|
When running frameIt it doesn't pickup those images shown above with he curl statement :(
Any further suggestions, I can’t get this to work now, it says it can’t find the 3rd gen item? |
@ConfusedVorlon Have you ran FrameIT for this device recently? |
not a clean version of FrameIt. (I think it is using my frame at the moment) |
OK, I've solved my problem, I think I must have had an old version of frameit installed, perhaps and uninstall and reinstall may have fixed this. However I've got some different paths, I also needed to diff my offsets file.
|
This did not work for me because frameit replaced '-' with ' ', which then leads to the program not being able to find the '12.9-inch' part of the string. Instead I used: curl https://user-images.githubusercontent.com/24507532/66273840-689ba700-e880-11e9-95e6-7ecb63728b2c.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Space\ Gray.png
curl https://user-images.githubusercontent.com/24507532/66273839-66394d00-e880-11e9-85cf-50f4dc0210c5.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Silver.png
# Remove last two lines
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
cat >> ~/.fastlane/frameit/latest/offsets.json <<EOL
,
"iPad Pro (12.9 inch) (3rd generation)": {
"offset": "+120+206",
"width": 2048
}
}
}
EOL |
Hi, Apple metadata rejected due 12.9-inch iPad Pro screenshots do not display the app in the correct device frame, iPad Pro (3rd Gen) doesn't have the home button.
Is there a way to force the device frame by Apple?
Thanks.
The text was updated successfully, but these errors were encountered: