Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nexus 5x fix and regenerate uses new “legacy” devices in fastlane framit generate directory #20

Closed
wants to merge 5 commits into from
Closed

Nexus 5x fix and regenerate uses new “legacy” devices in fastlane framit generate directory #20

wants to merge 5 commits into from

Conversation

joshdholtz
Copy link
Member

@joshdholtz joshdholtz commented Mar 23, 2021 •
edited
Loading

@google-cla google-cla bot added the cla: yes label Mar 23, 2021
This was referenced Mar 23, 2021
Merged
Closed
@thillsman
Copy link
Contributor

thillsman commented Mar 24, 2021 •
edited
Loading

It looks like this was bitten by the issue I ran into with quotation marks. My fix in fastlane/fastlane#18448 will prevent this incorrect naming (screenshot from this PR).

Screen Shot 2021-03-24 at 12 29 34 PM

(That renamed version should be "Apple iPad Pro 12.9...")

@joshdholtz
Copy link
Member Author

Closing in favor of #21

@joshdholtz joshdholtz closed this Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshdholtz @thillsman