Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TLSTotal Metric #133

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Update TLSTotal Metric #133

merged 1 commit into from
Jun 26, 2023

Conversation

leklund
Copy link
Member

@leklund leklund commented Jun 9, 2023

  • Removes "any" label - This is the sum across all TLS versions
  • Standardize version labels: 1.2 instead of v12

Fixes #121

@leklund leklund added the breaking-change Breaking Change label Jun 9, 2023
crivera-fastly
crivera-fastly reviewed Jun 20, 2023
View reviewed changes
pkg/realtime/process.go
m.TLSTotal.WithLabelValues(serviceID, serviceName, datacenter, "v11").Add(float64(stats.TLSv11))
m.TLSTotal.WithLabelValues(serviceID, serviceName, datacenter, "v12").Add(float64(stats.TLSv12))
m.TLSTotal.WithLabelValues(serviceID, serviceName, datacenter, "v13").Add(float64(stats.TLSv13))
m.TLSTotal.WithLabelValues(serviceID, serviceName, datacenter, "1.0").Add(float64(stats.TLSv10))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code change looks fine, but is this going to break existing graphs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it will. This change and the KV Store rename will have to be released as a new major version with some release notes indicating the breaking change.

@leklund leklund merged commit 3820552 into main Jun 26, 2023
@leklund leklund deleted the tls_versions branch June 26, 2023 21:22
This was referenced Apr 21, 2024
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crivera-fastly crivera-fastly crivera-fastly approved these changes

Assignees
No one assigned
Labels
breaking-change Breaking Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove tls_version="any" from fastly_rt_tls_total
2 participants
@leklund @crivera-fastly