Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New HTTPTotal Metric for all http requests #134

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

leklund
Copy link
Member

@leklund leklund commented Jun 9, 2023

Fixes #122

Adds new HTTPTotal metric all requests by http_version:

fastly_rt_http_total{datacenter="BUR",http_version="1"}
fastly_rt_http_total{datacenter="BUR",http_version="2"}
fastly_rt_http_total{datacenter="BUR",http_version="3"}

This PR does not remove the existing HTTP2Total or HTTP3Total metrics so as not to introduce a breaking change.

adds new HTTPTotal metric all requests by http_version:
```
fastly_rt_http_total{datacenter="BUR",http_version="1"}
fastly_rt_http_total{datacenter="BUR",http_version="2"}
fastly_rt_http_total{datacenter="BUR",http_version="3"}
```

This PR _does not_ remove the existing HTTP2Total or HTTP3Total metrics
so as not to introduce a breaking change.
@leklund leklund added the enhancement New feature or request label Jun 9, 2023
@leklund leklund merged commit 4b2196f into main Jun 26, 2023
@leklund leklund deleted the http_total_by_version branch June 26, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metric consolidation for http2/http3
2 participants