Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aggregated domain metrics test fixture #168

Merged
merged 1 commit into from
May 27, 2024
Merged

Fix aggregated domain metrics test fixture #168

merged 1 commit into from
May 27, 2024

Conversation

mikelorant
Copy link
Contributor

The aggregated metrics for the domain test had the host incorrectly set.

Fixed the indentation to be consistent with the other fixtures.

The aggregated metrics for the domain test had the host incorrectly
set.

Fixed the indentation to be consistent with the other fixtures.

Signed-off-by: Michael Lorant <[email protected]>
@mikelorant
Copy link
Contributor Author

@leklund While implementing the tests for the domain metrics, I found that the domain was marked as an origin (likely copied from the origin metrics). This caused the tests to fail:

 - 	`testspace_domain_bereq_body_bytes_total{datacenter="aggregate",domain="testhost",service_id="my-service-id",service_name="my-service-name"}`:                         16,
 + 	`testspace_domain_bereq_body_bytes_total{datacenter="aggregate",domain="testorigin",service_id="my-service-id",service_name="my-service-name"}`:                       16,

Since this is unrelated to the aggregated metrics, felt it was better to put this up as a separate pull request.

@leklund leklund merged commit b1e96b3 into fastly:main May 27, 2024
6 checks passed
@mikelorant mikelorant deleted the fix/aggregated-domain-fixture branch May 27, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants