Refactor operations #23
Conversation
kvesteri
commented
Aug 23, 2014
kvesteri
commented
- Make copy_database use new template parameter of create_database function
- Update SA-Utils dependency to 0.26.13
- Make copy_database use new template parameter of create_database function - Update SA-Utils dependency to 0.26.13
| ) | ||
| sqlalchemy_utils.functions.create_database( | ||
| '%s%s' % (raw_conn.engine.url, to_database), | ||
| template=from_database |
There was a problem hiding this comment.
Could we consider checking if the function exists, use it if it does and fallback to the current mechanism if it doesn't?
That would avoid having to rely on the latest sqlalchemy-utils
There was a problem hiding this comment.
@pypingou , it was 3 years ago, but from your requirements.txt it looks like you do rely on sqlalchemy-utils and operations.py imports it so it looks like the idea contained in this pull request could be merged.
There was a problem hiding this comment.
The point was not about relying on something that is already listed in the dependency list but about being more flexible on versions sqlalchemy-utils required.
After three years I think this point is no longer valid (and I even wonder how/why you digged up this comment ^^)
There was a problem hiding this comment.
Because it's open! I had a quick look and didn't really understood what is it about, you do rely on sqlalchemy-utils.
What's interesting is, why was I looking at the bug tracker. The reason is, I was wondering if I should add a command-line option to use another configuration file (different filename). The two or three times I thought this would be useful I ended up doing some other solution instead.
This whole stellar package is interesting. The functionality is so small and provided by PostgreSQL already it makes me wonder if I really need this package. On the other hand there is something really tempting about just typing "stellar restore" and having things done. On another, stellar is the thing I learned "CREATE TABLE FROM TEMPLATE" about.
Anyways.
There was a problem hiding this comment.
Because it's open!
Fair point, I had not realized this, but I doubt that it is my 3 years old comment that is preventing this PR from being merged.
It looks like the last commit on this project is from 2 years ago, so this project seems a little dead now, pity :(
There was a problem hiding this comment.
It's just that the project has reached a point where it works good enough so there hasn't really been any need for changes. I'm still using it every week so it's far from being abandoned.
There was a problem hiding this comment.
@Frozenball glad to have you here, I'm also regular stellar user
