Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop actionview dependency #26

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Drop actionview dependency #26

merged 2 commits into from
Oct 28, 2021

Conversation

etagwerker
Copy link
Member

Hi there,

This library doesn't really depend on actionview at all (not even as a dev dep) so I thought it was a good idea to drop that development dependency...

Please check it out.

Thanks!

@etagwerker etagwerker requested review from a team, lubc and kindoflew and removed request for a team October 23, 2021 01:28
Copy link

@lubc lubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@bronzdoc
Copy link

@etagwerker can you remove this please:

I remember it depended on it a few years ago :shipit: and I also removed it haha
ombulabs/next@272f08a

@etagwerker
Copy link
Member Author

@bronzdoc Yeah, I was almost sure we had removed it years ago...

I don't think it is necessary to remove that line in gem_info.rb, it is not really used to load anything, it is only used to check the compatibility with rails internal gems:

    def unsatisfied_rails_dependencies(rails_version:)
      rails_dependencies = gem_specification.runtime_dependencies.select {|dependency| rails_gems.include?(dependency.name) }

      rails_dependencies.reject do |rails_dependency|
        rails_dependency.requirement.satisfied_by?(Gem::Version.new(rails_version))
      end
    end

    def from_rails?
      rails_gems.include?(name)
    end

@bronzdoc bronzdoc merged commit 3c99380 into main Oct 28, 2021
@bronzdoc bronzdoc deleted the feature/remove-unnecessary-dep branch October 28, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants