Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make actionview an optional dependency #6

Merged
merged 3 commits into from
Sep 15, 2020

Conversation

manuca
Copy link

@manuca manuca commented Sep 14, 2020

Resolves #5

Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manuca I understand that actionview can be an optional dependency because of this:

https://github.com/fastruby/next_rails/blob/master/lib/next_rails/gem_info.rb#L1-L5

And this: https://github.com/fastruby/next_rails/blob/master/lib/next_rails/gem_info.rb#L55-L59

But I have a question about activesupport.

@@ -24,10 +24,11 @@ Gem::Specification.new do |spec|
spec.require_paths = ["lib"]

spec.add_dependency "colorize", ">= 0.8.1"
spec.add_dependency "activesupport", "< 6.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manuca How come this is necessary now?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manuca Weird. And where is that code getting called? What methods are we using from active_support?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which to be honest I have no idea why we're depending on it as there are no acts_like? calls anywhere as far as I've searched.

For reference this is acts_like.rb:
https://github.com/rails/rails/blob/5-2-stable/activesupport/lib/active_support/core_ext/object/acts_like.rb

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etagwerker I removed the activesupport dependency. Specs pass and bundle_report seems to work as expected.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manuca Interesting. I ran into the reference to acts_like? in v1.0.3: #21. I guess it is getting used in the exe command.

Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manuca Great, thanks! 👍

@etagwerker etagwerker merged commit a325fe0 into fastruby:master Sep 15, 2020
@manuca manuca deleted the make-actionview-optional branch September 15, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors when running on Ruby 2.3 and Rails 2.3 LTS
2 participants