Update KernelWarnTracker#warn signature to match Kernel#warn
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusdeap
requested review from
ashwinisukale and
KostiantynPopovych
and removed request for
a team
mateusdeap
requested review from
etagwerker
and removed request for
KostiantynPopovych
etagwerker
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug that arises when we set up the deprecation tracker with a
transform_messageoption that manipulates messages as if they wereStrings.Motivation and Context
Fixes #81
Although manipulating the messages as if they were
Strings is expected, as of Ruby 2.5, calls toKernel.warn, which we override, may be given an optionaluplevelkeyword argument. Since our override doesn't account for this in the signature, the keyword arg get's passed to the callback method as aHashand will cause an error.How Has This Been Tested?
This PR adds the appropriate test case
I will abide by the code of conduct