fix: revert gorilla/websocket from 1.5.1 to 1.5.0 #4149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
added a commit
to aiastia-dockerhub/frp
that referenced
this pull request
Apr 11, 2024
* https://github.com/fatedier/frp: show tcpmux proxies on the frps dashboard (fatedier#4152) return 504 instead of 404 for proxy type http request timeout (fatedier#4151) fix: revert gorilla/websocket from 1.5.1 to 1.5.0 (fatedier#4149)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
gorilla/websocket 1.5.1 is a problematic version.
There will be a lot of logs about websocket because they use
log.Prinfdirectly in the code to print errors. For details, see: gorilla/websocket#880And websocket 1.5.1 seems to have changed some other features that should not be added. I think frp should roll back the websocket version to 1.5.0 to avoid these problems.