Feature: Add remove api for offline proxy #4422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add api to remove a single proxy with name and type example: curl -X DELETE -u admin:admin -v http://127.0.0.1:7500/api/proxy/tcp/test-tcp output: proxy "test-tcp" deleted
|
@fatedier Please take a review |
|
Currently, there are no plans to support this API, and only the option to clear all is provided in the dashboard. |
I am adding via this PR. In our case, we check the proxy status via get api, we also want delete api to manually remove some unwanted or unexpected proxies on purpose. |
|
PRs go stale after 21d of inactivity. Stale PRs rot after an additional 7d of inactivity and eventually close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds api to remove a single proxy with name and type example:
curl -X DELETE -u admin:admin -v http://127.0.0.1:7500/api/proxy/tcp/test-tcp
output:
proxy "test-tcp" deleted
WHY
Currently, only clear all offline proxy api is provided, this PR provides api for singe proxy removal