Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support multiple subjects in oidc ping #4475

Merged
merged 1 commit into from
Oct 12, 2024
Merged

support multiple subjects in oidc ping #4475

merged 1 commit into from
Oct 12, 2024

Commits on Oct 11, 2024

  1. support multiple subjects in oidc ping 

    Validate the subject in an oidc ping against a list of logged in subjects.

This resolves the issue that multiple connected FRP clients with different
OIDC clients result in a failing ping. The ping would fail because the
subject in memory would be the value of the last logged in FRPC.

This change also changes the constructor of OidcAuthVerifier to take
a TokenVerifier interface. This will not change production behavior, but makes
testing easier because we can inject a mock verifier during testing.

Resolves: fatedier#4466
    Rob Kenis committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    d082976 View commit details
    Browse the repository at this point in the history