-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docstring of known_hash
in retrieve
function
#333
Improve docstring of known_hash
in retrieve
function
#333
Conversation
💖 Thank you for opening your first pull request in this repository! 💖 A few things to keep in mind:
⭐ No matter what, we are really grateful that you put in the effort to do this! ⭐ |
I am a bit surprised about the single pipeline failure. As I did not touch any code, I can hardly believe those failures are really related to my very minor change. Or is there something I missed? |
Thanks @BjoernLudwigPTB for this contribution! Don't worry, your change cannot trigger any test failure. Apparently the downloaded file got corrupted and the hash didn't matched, which proves that including checksums in Pooch was a great idea from the start. I rerun it. Let's wait until it passes and I'll merge this PR 🚀 . |
known_hash
in retrieve
function
🎉 Congrats on merging your first pull request and welcome to the team! 🎉 If you would like to be added as a author on the Zenodo archive of the next release, add your full name, affiliation, and ORCID (optional) to the We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved. |
@santisoler Say, am I really invited, for such a small contribution, to join the AUTHORS.md? I would love to, but it feels a bit awkward as I imagine, most if not all the others did actually contribute much more useful things. |
Yes @BjoernLudwigPTB! Every person that makes a contribution to our packages is automatically a contributor, so your GitHub handle and/or name will appear in our changelog. Every contributor can opt-in to be in the Feel free to add yourself if that's what you desire. If not, don't worry. It's ok to opt-out if you aren't interested in that. You contribution and any future ones will still be very welcomed! |
Thanks for having me!
Specify that
known_hash
can also beNone
in theretrieve
functiondocstring. This change helps some IDEs to identify
None
as a valid value forthe
known_hash
argument.My IDE complains about None as being not allowed as described in the corresponding issue.
Relevant issues/PRs:
Fixes #332.