Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Rio sample magnetic data #201

Closed
leouieda opened this issue Sep 19, 2019 · 2 comments
Closed

Remove the Rio sample magnetic data #201

leouieda opened this issue Sep 19, 2019 · 2 comments
Labels
maintenance A maintenance task to improve development
Milestone
v2.0.0

Comments

@leouieda
Copy link
Member

This dataset doesn't make much sense here in Verde and the license for the data is unclear. We could remove the data in two stages:

  1. For 1.2.0: Add a deprecation warning to the loading function saying that the dataset is deprecated and will be removed in the next release.
  2. For the following release: remove the dataset and the loading function. This is only used in examples and is not critical infrastructure for anyone (or at least it shouldn't).
leouieda added a commit that referenced this issue Nov 25, 2019
@leouieda
Add deprecation warning for Rio sample data
4311a97 
Licensing for the dataset is unclear it's best to remove it. We'll
deprecate first and then remove in a future major release. Add warnings
to the docstrings and sample data example. Replace the Rio data with
Texas wind in the Trend gallery example (it's already used in the trend
estimation tutorial). See #201 for more context.
@leouieda leouieda mentioned this issue Nov 25, 2019
Merged
5 tasks
@leouieda leouieda added this to the v2.0.0 milestone Nov 25, 2019
leouieda added a commit that referenced this issue Dec 9, 2019
@leouieda
Add deprecation warning for Rio sample data (#213)
f020804 
Licensing for the dataset is unclear it's best to remove it. We'll
deprecate first and then remove in a future major release. Add warnings
to the docstrings and sample data example. Replace the Rio data with
Texas wind in the Trend gallery example (it's already used in the trend
estimation tutorial). See #201 for more context.
@leouieda
Copy link
Member Author

leouieda commented Jan 16, 2020 •
edited
Loading

The dataset and associated functions have been deprecated. They should only be removed just before releasing v2.0.0.

@leouieda leouieda added the maintenance A maintenance task to improve development label Oct 3, 2021
@leouieda
Copy link
Member Author

Replaced by #350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance A maintenance task to improve development
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@leouieda