Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples and tests to pass with Numpy 2 #459

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Fix examples and tests to pass with Numpy 2 #459

merged 4 commits into from
Jul 31, 2024

Conversation

santisoler
Copy link
Member

Cast Numpy floats and ints to Python floats so doctests can pass using both Numpy <2 and >=2. Update test that was checking floats with regex.

Cast Numpy floats and ints to Python floats so doctests can pass using
both Numpy <2 and >=2. Update test that was checking floats with regex.
@santisoler santisoler marked this pull request as ready for review July 23, 2024 18:58
@santisoler santisoler requested a review from leouieda July 23, 2024 18:58
Copy link
Member

@leouieda leouieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@leouieda leouieda merged commit 75f8156 into main Jul 31, 2024
18 checks passed
@leouieda leouieda deleted the numpy-2.0.0 branch July 31, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants