-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ordered ACL output actions #3476
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3476 +/- ##
==========================================
- Coverage 92.49% 92.36% -0.13%
==========================================
Files 42 42
Lines 7878 8061 +183
==========================================
+ Hits 7286 7445 +159
- Misses 592 616 +24
Continue to review full report at Codecov.
|
396bcb4
to
9324425
Compare
Looking into the test failures now - looks like config change detection problems revealed by my refactoring. |
Will fix - sorry for the inconvenience. |
Should be all sorted now. The FaucetUntaggedPortSwapIPv4InterVLANRouteTest flake is fixed by #3487 |
This is all sorted on my part too. |
LGTM now 👍 |
Allow ordered ACL output actions as mentioned in #3468 (Closes #3468).
Fix #3389
Allow defining a tunnel without requiring a VLAN, Faucet will pick an unused VID that is larger than the configured VIDs (Closes #3314).
e.g.: The following config will create a tunnel that will be encapsulated with VID 101
Tunnel ACLs will pop off the encapsulation after the output action so rules can now be applied after a tunnel action. e.g.: The output to port 6 will not have the tunnel VID applied