-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method to RocksDB for backing up partitions #304
Conversation
I'm satisfied with the changes I have now. If you have any other changes you'd like to see, let me know. I haven't done any testing for Aerospike, but it seems possible to backup a table from what's done in https://github.com/aerospike/aerospike-tools-backup/blob/fc348e6016cdfccc0e75a6b76621067e57d2a11c/test/integration/run_backup.py. |
I forgot to test some last-minute changes earlier. I've tested everything and runs properly now. |
Removed import of |
I'm not sure where this should be added, but according to https://fauststream.slack.com/archives/C7FL9CB5E/p1594816114113200?thread_ts=1594815786.109000&cid=C7FL9CB5E, recoveries are automatically triggered when a table is accessed. After testing further, it seems that calling |
On further testing, it appears that the current release of https://github.com/faust-streaming/python-rocksdb is fine for accessing the backup functions in |
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
==========================================
- Coverage 94.66% 94.42% -0.25%
==========================================
Files 100 100
Lines 10855 10903 +48
Branches 1520 1529 +9
==========================================
+ Hits 10276 10295 +19
- Misses 505 533 +28
- Partials 74 75 +1
Continue to review full report at Codecov.
|
I'd like to squash a lot of these commits before merging... unless the maintainers have the option to automatically do that 😄 |
I have a specific use-case where I need to actively backup a RocksDB store. I've had success using
rocksdb.BackupEngine
withfaust
but it'd be much more usable if the code was integrated intofaust
.I should note I've only had success with this using
librocksdb-dev==6.11.4-3
on Ubuntu 22.04 and the python-rocksdb bindings from https://github.com/NightTsarina/python-rocksdb.If you have interest in this, let me know because I really need this feature.