If changelog topic partitions are only listed in the actives_tps set … #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and not in standbys, then those partitions need to be resumed to ensure GlobalTable stays in sync for all workers
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 100 100
Lines 10855 10855
Branches 1520 1520
=======================================
Hits 10276 10276
Misses 505 505
Partials 74 74 Continue to review full report at Codecov.
|
patkivikram
approved these changes
Jul 19, 2022
elrik75
pushed a commit
to Kadiska/faust
that referenced
this pull request
Aug 2, 2022
…tps set … (faust-streaming#325)" This reverts commit c4f5b18.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created to address #283, credit goes to @lorinmetzger for the fix.