Crossterm Performance Update #173
Conversation
TimonPost
changed the title
|
How it used to be: How it looks like with the update:
It is ready to be released, I updated the version of crossterm |
TimonPost
changed the title
|
This is awesome! To be honest, i'm kind of appalled by the performance of powershell / cmd in general, but especially in combination with interactive terminal applications. I'm seeing some serious memory leaks in the underlying console subsystem, see tokio-rs/console#22 . I will report back whether this solves it! |
|
@fdehau can this be merged? |
Cargo.toml
Outdated
| @@ -28,9 +28,9 @@ log = "0.4" | |||
| either = "1.5" | |||
| unicode-segmentation = "1.2" | |||
| unicode-width = "0.1" | |||
| termion = { version = "1.5", optional = true } | |||
| termion = { version = "1.0" , optional = true } | |||
There was a problem hiding this comment.
why a change on the termion version ?
There was a problem hiding this comment.
Ah, good catch, I was trying something out there. But should be reverted.
|
Beside my small comment, this is great work and I would be happy to merge it. Could you maybe also squash some commits to make all of them relevant ? I'm thinking that because of the breaking changes in the public api this is going to be in a 0.7 release. |
|
Awesome, I'll squash my commits, and yes it has braking changes so a new version is required. |
|
squashed! |
I have been working on improving the performance of crosterm. The status can be followed here:crossterm-rs/crossterm#175. On windows, the performance increased with 60% and on Linux, the performance increased with +- 40% .
This is positive for TUI, and now there are no glitches anymore in the screen.
Before:
After
The noticeable change is, especially in the windows implementation. Windows is way slower with terminal actions. Like I had a benchmark where I did some stuff on windows it took 5 seconds to complete and on Linux it took less than one second.
For now, this should not be merged yet. I am still working on it, and once crossterm 0.10 releases I will update this PR as well.