Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deserialize plain DI certs as raw DER #553

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Deserialize plain DI certs as raw DER #553

wants to merge 1 commit into from

Commits on Sep 7, 2023

  1. Deserialize plain DI certs as raw DER 

    Because of the deserialize implementation that's automatically
generated, at this moment the expected value for the public_key_store
in the manufacturing server is a CBOR array of the DER certificate.
This commit adds a new type PlainBytes which (de)serializes
transparently, and makes the manufacturing server use it for the public
key store.

NOTE: this means that with this patch, the store format on disk changes.
This store is a ReadOnly (the server will never write to it), but if
anyone would've put a CBOR file in place, that will now fail to open.
Raw DER was always the intention (and documented) format, but it still
is a risk.

Signed-off-by: Patrick Uiterwijk <[email protected]>
Fixes: fdo-rs#477
    @puiterwijk
    puiterwijk committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    abc9043 View commit details
    Browse the repository at this point in the history