Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement interpreter #26

Merged
merged 14 commits into from
Sep 30, 2023
Merged

Implement interpreter #26

merged 14 commits into from
Sep 30, 2023

Conversation

k0aki
Copy link
Contributor

@k0aki k0aki commented Sep 6, 2023 •
edited
Loading

Implements interpreter state and instruction execution for sonatina IR

  • operates on module-level
  • handles constant global values

@k0aki k0aki marked this pull request as draft September 6, 2023 14:49
@k0aki k0aki force-pushed the interpreter branch 3 times, most recently from 450dd45 to f554d9f Compare September 13, 2023 17:38
@k0aki k0aki marked this pull request as ready for review September 13, 2023 17:43
Y-Nak
Y-Nak reviewed Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@Y-Nak Y-Nak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems nice overall!

I left some comments, which are mainly to have a clear boundary between frame and evaluation implementation.

crates/interpreter/Cargo.toml Outdated Show resolved Hide resolved
crates/interpreter/src/frame.rs Outdated Show resolved Hide resolved
crates/interpreter/src/frame.rs Outdated Show resolved Hide resolved
crates/interpreter/src/frame.rs Outdated Show resolved Hide resolved
crates/interpreter/src/frame.rs Outdated Show resolved Hide resolved
crates/interpreter/src/frame.rs Outdated Show resolved Hide resolved
crates/interpreter/src/frame.rs Outdated Show resolved Hide resolved
crates/interpreter/src/frame.rs Outdated Show resolved Hide resolved
crates/interpreter/src/state.rs Outdated Show resolved Hide resolved
crates/interpreter/src/state.rs Outdated Show resolved Hide resolved
@k0aki k0aki force-pushed the interpreter branch 2 times, most recently from a658f73 to 84e3cc8 Compare September 25, 2023 12:54
Y-Nak
Y-Nak reviewed Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@Y-Nak Y-Nak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left some nits. I think we can merge this when the nits are addressed.

crates/interpreter/src/frame.rs Outdated Show resolved Hide resolved
crates/interpreter/src/types.rs Outdated Show resolved Hide resolved
crates/interpreter/src/value.rs Outdated Show resolved Hide resolved
crates/interpreter/src/value.rs Outdated Show resolved Hide resolved
Y-Nak
Y-Nak approved these changes Sep 30, 2023
View reviewed changes
Copy link
Collaborator

@Y-Nak Y-Nak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks!

@Y-Nak Y-Nak merged commit d2c9ed0 into fe-lang:main Sep 30, 2023
9 checks passed
@k0aki k0aki deleted the interpreter branch September 30, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Y-Nak Y-Nak Y-Nak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k0aki @Y-Nak