Skip to content

Commit

Permalink
Update error message
Browse files Browse the repository at this point in the history
Signed-off-by: Achal Shah <[email protected]>
  • Loading branch information
achals committed Jun 9, 2021
1 parent 0ee858d commit 41136c8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sdk/python/feast/errors.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ def __init__(self, expected, missing):


class FeastJoinKeysDuringMaterialization(Exception):
def __init__(self, join_key_columns: Set[str], source_columns: Set[str]):
def __init__(self, source: str, join_key_columns: Set[str], source_columns: Set[str]):
super().__init__(
f"The DataFrame being materialized must have at least {join_key_columns} columns present, "
f"The DataFrame from {source} being materialized must have at least {join_key_columns} columns present, "
f"but these were missing: {join_key_columns - source_columns} "
)
1 change: 1 addition & 0 deletions sdk/python/feast/infra/offline_stores/file.py
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ def pull_latest_from_table_or_query(
source_columns = set(source_df.columns)
if not set(join_key_columns).issubset(source_columns):
raise FeastJoinKeysDuringMaterialization(
data_source.path,
set(join_key_columns), source_columns
)

Expand Down

0 comments on commit 41136c8

Please sign in to comment.